Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected Tests, new RPC Messages, new Events, RTM Changes for new PresenceSub #130

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Corrected Tests, new RPC Messages, new Events, RTM Changes for new PresenceSub #130

wants to merge 4 commits into from

Conversation

smorey2
Copy link

@smorey2 smorey2 commented Jan 12, 2018

EXISTING

  • Cleaned up source code, removed extra usings, did Visual Studio auto format, standardized var
  • Corrected existing tests, to ensure they pass. Channel name is no longer a valid parameter to most functions.

NEW

  • Added 12 new RPC Messages
  • Added events for OnPresenceChangeReceived and OnUserChangeReceived
  • Added PresenceSub and Login parameters for RTM Change
  • Added Test fixture and PresenceSubscription Test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@smorey2